ingydotnet / yaml-libyaml-pm

Perl Binding to libyaml
http://search.cpan.org/dist/YAML-LibYAML/
33 stars 37 forks source link

t/regexp.t failing with perl < 5.14 #11

Open pghmcfc opened 9 years ago

pghmcfc commented 9 years ago

Seen this with 5.10.x and 5.12.x:

$ make test
make[1]: Entering directory `/builddir/build/BUILD/YAML-LibYAML-0.53/LibYAML'
make[1]: Leaving directory `/builddir/build/BUILD/YAML-LibYAML-0.53/LibYAML'
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/000-require-modules.t .. ok
t/alias.t ................ ok
t/api.t .................. ok
t/ascii.t ................ ok
t/blessed.t .............. ok
t/boolean.t .............. ok
t/bug-pvf.t .............. ok
t/bug-stack.t ............ ok
t/code.t ................. ok
t/dump.t ................. ok
t/empty.t ................ ok
t/error.t ................ ok
t/file.t ................. ok
t/glob.t ................. ok
t/leak.t ................. ok
t/load.t ................. ok
t/loadfile-empty.t ....... ok
t/long_plain_wrap.t ...... skipped: Failing test. Not yet implemented
t/magic.t ................ ok
t/native.t ............... ok
t/null.t ................. ok
t/numbers.t .............. ok
t/pl_sv_undef.t .......... ok
t/private.t .............. ok
t/quote.t ................ ok
t/ref-scalar.t ........... ok
#   Failed test 'Regular regexp dumps'
#   at t/regexp.t line 20.
#          got: '--- !!perl/regexp (?-xism:5050)
# ...
# '
#     expected: '--- !!perl/regexp (?-xism:5050)
# '
#   Failed test 'Blessed regular regexp dumps'
#   at t/regexp.t line 24.
#          got: '--- !!perl/regexp:Classy (?-xism:99999)
# ...
# '
#     expected: '--- !!perl/regexp:Classy (?-xism:99999)
# '
#   Failed test 'Regexp with flags dumps'
#   at t/regexp.t line 28.
#          got: '--- !!perl/regexp (?mi-xs:^edcba)
# ...
# '
#     expected: '--- !!perl/regexp (?mi-xs:^edcba)
# '
#   Failed test 'Blessed regexp with flags dumps'
#   at t/regexp.t line 35.
#          got: '--- !!perl/regexp:Bossy (?mi-xs:^edcba)
# ...
# '
#     expected: '--- !!perl/regexp:Bossy (?mi-xs:^edcba)
# '
#   Failed test 'Unicode regexp dumps'
#   at t/regexp.t line 43.
#          got: '--- !!perl/regexp (?-xism:Ā)
# ...
# '
#     expected: '--- !!perl/regexp (?-xism:Ā)
# '
# Looks like you failed 5 tests of 18.
t/regexp.t ............... 
Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/18 subtests 
t/release-pod-syntax.t ... skipped: these tests are for release candidate testing
t/string_nulls.t ......... ok
t/tags.t ................. ok
t/tied.t ................. ok
t/utf8.t ................. ok
Test Summary Report
-------------------
t/regexp.t             (Wstat: 1280 Tests: 18 Failed: 5)
  Failed tests:  1-5
  Non-zero exit status: 5
Files=32, Tests=270,  3 wallclock secs ( 0.12 usr  0.03 sys +  2.35 cusr  0.21 csys =  2.71 CPU)
Result: FAIL
Failed 1/32 test programs. 5/270 subtests failed.
make: *** [test_dynamic] Error 255

5.16.x onwards seem OK.

Please also consider fixing CVE-2012-1152 (https://rt.cpan.org/Public/Bug/Display.html?id=46507), for which there is a patch on RT.

KASTINpl commented 7 years ago

simillar problem on Fedora 25 with perl 5.24.0:

$ cpan install YAML::XS

t/numbers.t .............. ok   
t/path-class.t ........... ok   
t/pl_sv_undef.t .......... ok   
t/private.t .............. ok   
t/quote.t ................ ok   
t/ref-scalar.t ........... ok     
t/regexp.t ............... Can't locate Devel/Peek.pm in @INC (you may need to install the Devel::Peek module) (@INC contains: /root/.local/share/.cpan/build/YAML-LibYAML-0.63-rsjy_h/blib/arch /root/.local/share/.cpan/build/YAML-LibYAML-0.63-rsjy_h/blib/lib inc /root/.local/share/.cpan/build/YAML-LibYAML-0.63-rsjy_h/blib/lib /root/.local/share/.cpan/build/YAML-LibYAML-0.63-rsjy_h/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at t/regexp.t line 2, <CONFIG> line 1.
BEGIN failed--compilation aborted at t/regexp.t line 2, <CONFIG> line 1.
# Looks like your test exited with 2 before it could output anything.
t/regexp.t ............... Dubious, test returned 2 (wstat 512, 0x200)
Failed 18/18 subtests 
t/string_nulls.t ......... ok   
t/tags.t ................. ok   
t/tied.t ................. ok   
t/utf8.t ................. ok 

Test Summary Report
-------------------
t/regexp.t             (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 18 tests but ran 0.
Files=35, Tests=262,  3 wallclock secs ( 0.09 usr  0.03 sys +  3.11 cusr  0.32 csys =  3.55 CPU)
Result: FAIL
Failed 1/35 test programs. 0/262 subtests failed.
Makefile:911: polecenia dla obiektu 'test_dynamic' nie powiodły się
make: *** [test_dynamic] Błąd 255
  TINITA/YAML-LibYAML-0.63.tar.gz
  /bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
  reports TINITA/YAML-LibYAML-0.63.tar.gz
perlpunk commented 7 years ago

@KASTINpl that's actually a different error. Devel::Peek is in core, so I suspect you have to install 'perl-core' on Fedora additionally to 'perl' to get all the core modules.

KASTINpl commented 7 years ago

@perlpunk thanks for swift response

yes, correct, its not a lib issue, dnf install perl-core solved the problem, thanks!

I was confused because of:

$ cpan install Devel::Peek
Loading internal null logger. Install Log::Log4perl for logging messages
CPAN: Storable loaded ok (v2.56)
Reading '/root/.local/share/.cpan/Metadata'
  Database was generated on Tue, 03 Jan 2017 20:29:02 GMT
Running install for module 'Devel::Peek'
The most recent version "1.23" of the module "Devel::Peek"
is part of the perl-5.24.0 distribution. To install that, you need to run
  force install Devel::Peek   --or--
  install R/RJ/RJBS/perl-5.24.0.tar.gz
CPAN: Time::HiRes loaded ok (v1.9741)
pghmcfc commented 7 years ago

You can also do:

# dnf install 'perl(Devel::Peek)'

on Fedora to just get that module (and any dependencies it may need), if you don't want to install all of perl-core.