search

ingydotnet / yaml-libyaml-pm

Perl Binding to libyaml
http://search.cpan.org/dist/YAML-LibYAML/
33 stars 37 forks source link

Indents #89

Closed zdm closed 5 years ago

perlpunk commented 5 years ago

@zdm Could you please add a test? And add a variable declaration to lib/YAML/XS.pm so that we don't get a warning Name "YAML::XS::Indent" used only once: possible typo

zdm commented 5 years ago

Will do

On 07.11.2018 20:13, Tina Müller (tinita) wrote:

@zdm https://github.com/zdm Could you please add a test? And add a variable declaration to |lib/YAML/XS.pm| so that we don't get a warning |Name "YAML::XS::Indent" used only once: possible typo|

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ingydotnet/yaml-libyaml-pm/pull/89#issuecomment-436723055, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-mSDVmLL7JWMC2XxUh9p7ezJx84fICks5usyLYgaJpZM4YS7n0.

zdm commented 5 years ago

@perlpunk Done

zdm commented 5 years ago

@perlpunk Sorry, I am too hurried last time and committed tests with errors. Now it's passing all checks. Could you, please, accept this PR and make release on CPAN?

perlpunk commented 5 years ago

thanks, merged! I squashed and amended your commits (removed $YAML::Indent to be consistent because that's not how the other variables work right now)

zdm commented 5 years ago

@perlpunk Could you, please, release it, so people (and me ;-)) can use it? Thank you.

perlpunk commented 5 years ago

sorry, was very busy. released 0.75_001

zdm commented 5 years ago

Thanks

On 16.12.2018 19:29, Tina Müller (tinita) wrote:

sorry, was very busy. released 0.75_001

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ingydotnet/yaml-libyaml-pm/pull/89#issuecomment-447660910, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-mSLS9B4wAz_RnWuQVzmjD5ait0ioPks5u5oLegaJpZM4YS7n0.