search

inhabitedtype / angstrom

Parser combinators built for speed and memory efficiency
Other
637 stars 74 forks source link

Fix #152: Windows - Remove Symlinks #153

Closed bryphe closed 6 years ago

bryphe commented 6 years ago

This fixes #152, as symlinks on Windows don't always work well - they require elevation in general, meaning the git commands must be run as an administrator. There are some workarounds to get around this (like enabling Developer Mode), but they're not enabled out of the box, and that can make working with git repositories with symlinks challenging in a Windows environment.

There were two places with symlinks - the examples folder and the benchmarks folder. The http.ml and json.ml symlinks didn't seem to be used anywhere (in addition, the README.md just linked directly to the RFC files), so I removed those.

The benchmarks folder depended on the examples files to build - so I removed those symlinks, created a library in the examples folder, and referenced that library.

I'm not sure if this is the ideal fix, but it does improve the Windows experience since symlinks are no longer required. Let me know if you'd prefer a different approach, though! cc @hcarty

Thanks!

seliopou commented 6 years ago

I leave this in @hcarty's capable hands.

hcarty commented 6 years ago

This seems reasonable @bryphe - thanks!