Open reynir opened 1 year ago
When writing to a closed Faraday.t an exception Failure "cannot write to closed writer" is raised. I am observing this exception from Httpaf.Body.write_string, and I'm wary of catching all Failures. Could a more precise exception be used?
Faraday.t
Failure "cannot write to closed writer"
Httpaf.Body.write_string
Failure
https://github.com/inhabitedtype/faraday/blob/c66fc020fdc2327556c36fc1e912524b427d7da8/lib/faraday.ml#L193-L195
When writing to a closed
Faraday.tan exceptionFailure "cannot write to closed writer"is raised. I am observing this exception fromHttpaf.Body.write_string, and I'm wary of catching allFailures. Could a more precise exception be used?https://github.com/inhabitedtype/faraday/blob/c66fc020fdc2327556c36fc1e912524b427d7da8/lib/faraday.ml#L193-L195