search

inhindsight / hindsight

Apache License 2.0
12 stars 8 forks source link

Delete dataset (kill -9 method) #182

Closed kennyatpillar closed 4 years ago

kennyatpillar commented 4 years ago

Brutally remove all traces of a dataset. Any kind of graceful cleanup is out of scope and will be addressed in a later card.

kennyatpillar commented 4 years ago

@jeffgrunewald on your command about "why are we marking things done in a PR meant to delete the dataset" Once we implemented this, we found that in some events like "schedule:end" some state was being deleted. So we're marking things done when they are done, and deleting it in the delete event. If there's a time we are marking as done when we should have deleted, let us know.

ManApart commented 4 years ago

To Jeff's comment: We are COMPLETELY deleting the dataset from viewstate on reception of a delete event. We're just NOT deleting event state if say, a load has finished. This allows us to completely clean up a dataset without having to force the dataset event to know all implementation of every app.

Separate collections is another way we could solve this issue. I believe that that would create more complexity in the app (two gets or a third param etc) and is not worth the perceived performance benefit at this time. I'm fine with us doing two collections if we decide it's worth it.

I think we should always be asking about JSR, and if we're not that's a red flag to me. That being said, the JSR of JSR is probably not best discussed in github comments.

To Johnson. Sounds good, I'd like to touch base with you on monday then.