search

inhindsight / hindsight

Apache License 2.0
12 stars 8 forks source link

Switch to use Postgres instead of Redis to store state #205

Closed kennyatpillar closed 4 years ago

jdenen commented 4 years ago

I still prefer the System.get_env/2 pattern, since it's both established throughout releases.exs and because I know it won't blow up platform_runner. If we switch to System.fetch_env!/1, running hindsight locally and running e2e tests become a PITA.

jdenen commented 4 years ago

@kennyatpillar @jmorris-pillar @jeffgrunewald

I'm working on some changes that dovetail nicely with this PR, and there's at least one sizeable change I'd like to make to this code. Since timing has become a concern, I'm going to take this PR off your hands @kennyatpillar and will get it merged to master alongside my changes.

jdenen commented 4 years ago

Closing, as this PR is being pulled in by #243