inhindsight / hindsight

Apache License 2.0
12 stars 8 forks source link

Remove service_define #238

Closed jdenen closed 4 years ago

jdenen commented 4 years ago
jeffgrunewald commented 4 years ago

Why not disable it from build and deploy and mark it as a "help wanted" to preserve that work. True, it's still in git history, but realistically when was the last time anyone dusted off git history to restart an effort that was put on hold? Realistically this means someone is (hopefully) going to come along and re-learn all the stuff that went into this and re-implement it from scratch.

jdenen commented 4 years ago

could just be disabled in the build/deploy process

It's going to sit untouched. If I add a new pattern to all the services (like I just did) am I going to ignore Define (like I just did)? Am I going to do that indefinitely? I would rather delete it and preserve it in Git history than have unmaintained code.

sets a pattern for how we would like this work to be done

Not sure I entirely agree. While the typespec stuff is something we'd likely reuse, this code sets us down the ReactJS path that I'm not sure we ultimately want.

Why not disable it from build and deploy and mark it as a "help wanted" to preserve that work

Because we're not going to maintain it. We're not going to update Define with the ViewState.Management pattern or any other new patterns moving forward. And if we're not going to do that, there's no reason to keep the code around.

re-learn all the stuff that went into this and re-implement it from scratch

No one is going to re-implement Define without talking to you, me, or @bbalser first. I'm pretty sure we can point them in the right direction.