search

inigmatus / GAP

Giving Aircraft a Purpose (GAP) - Air Flights, Tours, Coast Guard, STS
http://forum.kerbalspaceprogram.com/index.php?/topic/129208-contract-pack-giving-aircraft-a-purpose-gap-10-beta-air-flights-tours-coast-guard-sts-105jan-4-2016/
MIT License
8 stars 5 forks source link

CoastGuard-BuoyDrop - Science Buoy Transmit not Completing Contract when RemoteTech installed #161

Closed inigmatus closed 8 years ago

inigmatus commented 8 years ago

Reported by Ringkeeper: http://forum.kerbalspaceprogram.com/index.php?/topic/129208-contract-pack-giving-aircraft-a-purpose-gap-1021-air-flights-tours-coast-guard-sts-jan-11-2016/&do=findComment&comment=2380507

inigmatus commented 8 years ago

from Ringkeeper: The buoy was connected via a Sat to the Center, so that was not the problem. It uploaded also the science 100% (at least according to the status text in the top left corner) . But the contract did not recognise it.

Thats exactly the same problem the survey scanner/science lab had until the community fix for them. So i guess its not a problem of the GAP contract but a bug in RT.

inigmatus commented 8 years ago

Nightingale says if RemoteTech is throwing an exception on transmit, then it is a RemoteTech problem.

inigmatus commented 8 years ago

Will need to test buoy transmit with RT installed.

inigmatus commented 8 years ago

while testing, realized that transmitter check is failing due to RT rewriting the partModule in Module Manager. So fix is to add a check for RT and change

partModule = ModuleDataTransmitter

to

partModule = ModuleRTAntenna

and with this change I as able to transmit just fine and get contract to complete through a relay satellite.

inigmatus commented 8 years ago

Ran into problem implementing this. CKAN does not remove RemoteTech folder thus causing a patch based on NEEDS[RemoteTech] still to apply, and failing contract load since patched part does not exist. Currently not working:

@CONTRACT_TYPE[CoastGuard-DropBuoys]:FOR[KSC?Coast?Guard]:NEEDS[RemoteTech]:HAS[@MODULE[ModuleRTAntenna]]

so I gave up. and removed the antenna requirement. players should be able to figure out for themselves that their buoys need antennas based on the intro contract text, hopefully.