Contract Wright-Barnstorm: requirement Facility was not met

[inigmatus]

Needs review of reports that contract is appearing when it should not be.

From: https://forum.kerbalspaceprogram.com/index.php?/topic/129208-contract-pack-giving-aircraft-a-purpose-gap-129-air-flights-tours-coast-guard-sts-oct-28-2016/&do=findComment&comment=3157000

First of all, this is a great contract pack.

However, I had an issue with the first barnstorming contract. Whenever I accepted it, it would automatically fail on launch. Since I didn't find anything about anyone else having this issue before I did some digging through the log and managed to track down the cause.

[LOG 12:25:35.936] [INFO] ContractConfigurator.FacilityRequirement: Contract Wright-Barnstorm: requirement Facility was not met. In the file for the contract (Wright-Barnstorm.cfg), it said this in the relevant section for the facility requirement:

REQUIREMENT
{
    name = Facility
    type = Facility

    facility = ResearchAndDevelopment       
    minLevel = 3

    invertRequirement = true

}

I'm not sure what this is supposed to do but it doesn't say anything in the contract text about the level of the R&D facility. Mine was still level 1 and it's an early contract so a level 3 facility requirement doesn't really make sense? I assume "invertRequirement = true" should turn this into any level but level 3? I changed this to:

REQUIREMENT
{
    name = Facility
    type = Facility

    facility = ResearchAndDevelopment       
    minLevel = 1

    // invertRequirement = true

}

This stopped the contract from automatically failing on launch the next time I attempted it.

https://forum.kerbalspaceprogram.com/index.php?/topic/129208-contract-pack-giving-aircraft-a-purpose-gap-129-air-flights-tours-coast-guard-sts-oct-28-2016/&do=findComment&comment=3157336

[inigmatus]

it did show up and then failed only after switching to an active vessel (so either on launch or when switching to a plane on the runway for example). Maybe @nightingale has an idea what's going on there?

from: https://forum.kerbalspaceprogram.com/index.php?/topic/129208-contract-pack-giving-aircraft-a-purpose-gap-129-air-flights-tours-coast-guard-sts-oct-28-2016/&do=findComment&comment=3157738

[inigmatus]

Looks like the fix is to remove invert requirement and specify min facility level.

For the record, the barnstorm contracts are only limited to facility level when there is an actual walkway to barnstorm, or room for the barn. I'll have to look at the barnstorm contracts to make sure all is working as intended.