Add ppmd based on LZMA SDK 22.01 (thanks to @pps83)

inikep / lzbench

lzbench is an in-memory benchmark of open-source LZ77/LZSS/LZMA compressors

894 stars 182 forks source link

Add ppmd based on LZMA SDK 22.01 (thanks to @pps83) #121

Open pps83 opened 1 year ago

pps83 commented 1 year ago

sounds stupid to say thanks to @myself, I simply based entire PR on some other diff that added another codec

tansy commented 1 year ago

All those functions ( pmalloc(), pfree(), CharWriter, CharWriterFunc() ) should be moved to lzbench_ppmd_compress(). They are small enough to move to the function body. Compressors.cpp is not private yard, it's public space and you should not litter it.

pps83 commented 10 months ago

@tansy sorry for late reply. PR updated.

pps83 commented 10 months ago

FYI, when I tried to use latest LZMA SDK 23.01 (instead of 22.01) I got compilation errors because lzbench already contains older lzma sdk parts (specifically 7zTypes.h, Compiler.h, Precomp.h and others are conflicting). With 22.01 at least it compiles cleanly.

when lzma is updated to 23.01, libppmd should also be updated to 23.01 at the same time

FYI @inikep