search

inikulin / ineed

Web scraping and HTML-reprocessing. The easy way.
MIT License
393 stars 13 forks source link

Drop Node <6 and bump request version #6

Closed strugee closed 5 years ago

strugee commented 5 years ago

This squashes a whooooole lot of deprecation and security warnings. Test suite passes OK.

strugee commented 5 years ago

Note that I didn't check the changelog too thoroughly, and IIRC request is known to not always respect semver like it should... I'll do it if I find the time but I figured the test suite passing was probably a pretty good indicator.

strugee commented 5 years ago

Aaaand sure enough CI failed because request dropped Node 0.10 support in a minor release. *deep sigh*

I pushed a new version just bumping to the last version to support 0.10. Although really I would recommend just dropping it...

strugee commented 5 years ago

So, it turns out that actually tests are failing even without this change because of a transient dep dropping support. So I decided to just bite the bullet and drop support for Node <6. That's what's in this PR now.

inikulin commented 5 years ago

Thanks!

strugee commented 5 years ago

Sure! Thank you!