search

inim-repl / INim

Interactive Nim shell / REPL / Playground
MIT License
644 stars 23 forks source link

Pin noise commit to include ktCtrlX change #107

Closed Tangdongle closed 4 years ago

Tangdongle commented 4 years ago

To avoid issues with inim pulling the wrong version of noise in. Should be merged once https://github.com/jangko/nim-noise/pull/11 is merged

Tangdongle commented 4 years ago

@0atman Hey mate, nim-noise has merged by commit. Can we please re-run the CI checks and then merge it in if all is good?

Fixes: https://github.com/inim-repl/INim/issues/106 and will prevent future issues around having the wrong nim-noise version checked out with nimble (ie if you had nim-noise v0.1.3 installed locally, perhaps from installing INim, and we just have require "nim-noise", that requirement has already been met so it won't update)

0atman commented 4 years ago

Wicked, thank you again @Tangdongle !