Closed josephnunn closed 6 years ago
I've merged this onto a new branch named python3. When the "few bugs" are fixed (care to share what those are?), we can think about merging this back to master, but before I do I'll create a python2 branch such that people who still need that can keep working with it.
Yes, this is due to the inclusion of several instances of weave code. Weave has never been ported to python 3 and never will be, cython is the commonly used replacement. I’ve not used cython before, but I’ve got the weave code out and am trying to run the tests with my cython code in the project but the tests are failing. When I sort cython out I will let you know.
Currently I’m swamped in graduate school, taking a class with Emre Neftci where I had to use pyNCSre. I mistakenly brought down pyNCS and began porting it so I could use it with Python 3.6. I hope to revisit this library soon to finish replacing weave with cython, I’m very close but the tests show no cigar!
Joseph
On Feb 08 , 2018, at 2:17 AM, Adrian M. Whatley notifications@github.com wrote:
I've merged this onto a new branch named python3. When the "few bugs" are fixed (care to share what those are?), we can think about merging this back to master, but before I do I'll create a python2 branch such that people who still need that can keep working with it.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/inincs/pyNCS/pull/31#issuecomment-364065969, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpIjJIW239Oo7he6flCPC1rtgjxlMHks5tSsm1gaJpZM4Ruz8r.
Also swapped out weave for cython, as weave is 2.7 only. EDIT: Got to fix a few bugs first, will update.