problem while testing - Githubissues

initOS / vault

Odoo Password Manager

5 stars 5 forks source link

problem while testing #1

Open ygol opened 3 years ago

ygol commented 3 years ago

Hi Florian. Trying to test your module.

Installed both vault & vault_share without problems.
Got asked for a password (or key). provided a password.
unable to add rights as vault is empty.
unable to add to inbox:
```
Validation Error
```

The operation cannot be completed:

Create/update: a mandatory field is not set.
Delete: another model requires the record being deleted. If possible, archive it instead.

Model: Vault share incoming secrets (vault.inbox), Field: Vault (user_id)

- unable to add to entries:

Validation Error

The operation cannot be completed:

Create/update: a mandatory field is not set.
Delete: another model requires the record being deleted. If possible, archive it instead.

Model: Entry inside a vault (vault.entry), Field: Vault (vault_id)



am I missing anything?

fkantelberg commented 3 years ago

Hi Yves,

not quite sure what went wrong with the entry. I'm currently aware of one bug where a vault isn't fully initialized when you skip clicking save during the creation of a vault. This can cause some of these side effects but it's hard to fully reproduce currently. Please try it with a new vault or fresh db. I have to track that one down.

rights: What have you tried there? If you want to add an user to a vault this user needs to have a public key stored in the database. This basically happens when Odoo first asks for the password for the private key. Means you have to login as the other user before.

inbox: I think I missed this workflow with the buttons in the tree view. Currently there are 2 workflows for the inboxes:

Using an inbox link: If you check the right top user menu you can see the key management and there you'll see an inbox link. With this link you can enter your secrets. Afterwards you are able to see the it in your inbox. The link at the inbox can be used to overwrite it again.
Next to the secrets in an entry are additional buttons. One will open a wizard which will send the secret to a persons inbox. Just hover over these for the info text.

I would just hide the buttons there and maybe offer the wizard too because creating an inbox makes only sense if you want to send secrets to other users.

ygol commented 3 years ago

rights it was empty. I tried adding one but can't because the vault field is empty. so I logged as another user (demo). I was asked for my password but then again I can't add rights for this user (demo).

Back logged as admin: trying to add an entry using the inbox link. It seem it requires a file to be added and then I get a message "No secret found"

I could get the wizard to share an entry to work. Should I see somewhere who has shared it and for the one I (admin) share; shouldn't we see to whom we shared it and when?

Entries are still empty and not allowing adding anything there:

fkantelberg commented 3 years ago

Ah now I see. The menu entries rights and entries are just overviews. I hope the new structure in the menu makes it a bit more clear.

Entries can be created in a vault. Click the menu entry Vault and then the smart button in the top right see the attached screenshot. screenshot-entries

I think I found the problem with the inbox because some of the odoo js wasn't loaded everything failed. It should be possible to upload a file or a secret but the encryption in the background failed. Seems like I had to clear the cache for my previous caches better.

Regarding the share: I guess I can show the sharing user there without a problem. The shares are working with the links. If somebody has the link (and pin) he can read it. If you share a secret you just send the link and pin to the persons which should get the secret. It will expire automatically though.

I hope it's a bit more clear. I'll put more infos in the readme.