initc3 / HoneyBadgerMPC

Robust MPC-based confidentiality layer for blockchains
GNU General Public License v3.0
131 stars 64 forks source link

Issues in tutorial/hbmpc-tutorial-2.py #374

Closed hugo-tardiou closed 4 years ago

hugo-tardiou commented 5 years ago

Hi found a two issues related to this file:

pp_elements is not defined line 77

https://github.com/initc3/HoneyBadgerMPC/blob/bb8a95384706fcb3cb6d05351ab15ad84d6a8ade/apps/tutorial/hbmpc-tutorial-2.py#L68-L78

pp_elements line 77 is outside the if condition Temp Solution: I moved line 72 before the if condition and it worked for me

--

https://github.com/initc3/HoneyBadgerMPC/blob/bb8a95384706fcb3cb6d05351ab15ad84d6a8ade/honeybadgermpc/preprocessing.py#L538-L542

When you run the script : scripts/launch-tmuxlocal.sh apps/tutorial/hbmpc-tutorial-2.py conf/mpc/local

It searches for the file sharedata/sharedata/READY when it needs to be sharedata/READY

Temp Solution: i removed f"{self.data_directory}" from line 540

--

I find these tutorials useful for understanding this library. I'm unsure how you want to permanently fix this, but in the meantime, anybody who wants to fix this issue can do it manually.

-- Hugo