initc3 / HoneyBadgerMPC

Robust MPC-based confidentiality layer for blockchains
GNU General Public License v3.0
133 stars 61 forks source link

Consider replacing PyCrypto with PyCryptodome #402

Open sbellem opened 4 years ago

sbellem commented 4 years ago

PyCryptodome can be used as: an almost drop-in replacement for the old PyCrypto library

PyCrytpo's development momentum seems to be paused since 2014; 58 pull requests currently open, 136 open issues. Currently fails for Python 3.8 because of its usage of time.clock -- trivial to fix though: https://github.com/dlitz/pycrypto/pull/296).

All in all, PyCryptodome appears to be a better option.

As a note: PyCrytpodome has an implementation of Shamir's Secret Sharing: https://github.com/Legrandin/pycryptodome/blob/master/lib/Crypto/Protocol/SecretSharing.py.

sanket1729 commented 4 years ago

Yes, we are already made this transition from pycryptodome to pycrypto for Crypto course this year.