initc3 / HoneyBadgerMPC

Robust MPC-based confidentiality layer for blockchains
GNU General Public License v3.0
131 stars 64 forks source link

Volume matching #406

Open lilione opened 4 years ago

lilione commented 4 years ago

Implement the volume matching algorithm and test cases for it.

sanket1729 commented 4 years ago

We can merge fixed point first. Then we can get this in

sanket1729 commented 4 years ago

Would require a rebase now

codecov[bot] commented 4 years ago

Codecov Report

Merging #406 into dev will decrease coverage by 0.23814%. The diff coverage is 66.66667%.

@@                 Coverage Diff                 @@
##                 dev        #406         +/-   ##
===================================================
- Coverage   77.02727%   76.78913%   -0.23815%     
===================================================
  Files             50          51          +1     
  Lines           5611        5743        +132     
  Branches         859         876         +17     
===================================================
+ Hits            4322        4410         +88     
- Misses          1113        1157         +44     
  Partials         176         176                 
amiller commented 4 years ago

We should try to use this PR as an example of the documentation style we want to see in contributed apps

sbellem commented 4 years ago

@lilione when you have a chance, could you rebase the PR so that CircleCI will be used to generate the docs and we can then preview them ...

sbellem commented 4 years ago

@yunqi I added some commits so that you can build and view the docs locally. To build and view the docs in your browser you can run:

$ make servedocs

To build the docs:

$ make docs

You then need to refresh the browser.

To view the auctions app docs go to http://localhost:58888/apps/auctions.html.

Let me know once you are setup!

sbellem commented 4 years ago

This is good to merge. The app works (python apps/auctions/volume-matching.py) and the documentation follows the numpy docstring style.

/cc @amiller