Open lilione opened 4 years ago
We can merge fixed point first. Then we can get this in
Would require a rebase now
Merging #406 into dev will decrease coverage by
0.23814%
. The diff coverage is66.66667%
.
@@ Coverage Diff @@
## dev #406 +/- ##
===================================================
- Coverage 77.02727% 76.78913% -0.23815%
===================================================
Files 50 51 +1
Lines 5611 5743 +132
Branches 859 876 +17
===================================================
+ Hits 4322 4410 +88
- Misses 1113 1157 +44
Partials 176 176
We should try to use this PR as an example of the documentation style we want to see in contributed apps
@lilione when you have a chance, could you rebase the PR so that CircleCI will be used to generate the docs and we can then preview them ...
@yunqi I added some commits so that you can build and view the docs locally. To build and view the docs in your browser you can run:
$ make servedocs
To build the docs:
$ make docs
You then need to refresh the browser.
To view the auctions app docs go to http://localhost:58888/apps/auctions.html.
Let me know once you are setup!
This is good to merge. The app works (python apps/auctions/volume-matching.py
) and the documentation follows the numpy docstring style.
/cc @amiller
Implement the volume matching algorithm and test cases for it.