initc3 / HoneyBadgerMPC

Robust MPC-based confidentiality layer for blockchains
GNU General Public License v3.0
128 stars 64 forks source link

Add check for docstring convention (PEP 257) #434

Closed sbellem closed 4 years ago

sbellem commented 4 years ago

What is this? Python has a style guide for docstrings in PEP 257. pydocstyle is a tool to check the docstrings according to the conventions in PEP 257.

The configuration is in setup.cfg under the [pydocstyle] section:

[pydocstyle]
convention=pep257
add_ignore=D100,D101,D102,D103,D104,D105,D107,D200,D202,D205,D208,D210,D400,D401,D402,D403

A complete list of error codes is at http://www.pydocstyle.org/en/5.0.2/error_codes.html.

Goal and direction

The goal of this pull request is to introduce the usage of pydocstyle to check docstrings but meanwhile tolerating a lot of "errors" with the intention of gradually fixing these errors and eventually requiring the numpy style of docstrings.

codecov[bot] commented 4 years ago

Codecov Report

Merging #434 into dev will decrease coverage by 0.07162%. The diff coverage is n/a.

@@                 Coverage Diff                 @@
##                 dev        #434         +/-   ##
===================================================
- Coverage   77.31423%   77.24261%   -0.07162%     
===================================================
  Files             50          50                 
  Lines           5585        5585                 
  Branches         856         856                 
===================================================
- Hits            4318        4314          -4     
- Misses          1094        1096          +2     
- Partials         173         175          +2