Closed sbellem closed 4 years ago
Merging #437 into dev will decrease coverage by
0.07162%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #437 +/- ##
===================================================
- Coverage 77.31423% 77.24261% -0.07162%
===================================================
Files 50 50
Lines 5585 5585
Branches 856 856
===================================================
- Hits 4318 4314 -4
- Misses 1094 1096 +2
- Partials 173 175 +2
When I run benchmark examples locally from this branch, they still do not seem to work: https://gist.github.com/amiller/e945f4b50e4d372f0fabd5072f6a0037
Should be fixed by 64584e0
The current error on Travis CI is documented in https://github.com/initc3/HoneyBadgerMPC/issues/438.
Will take care of this asap.
UPDATE: fixed via #441.
Equality
share comparison class.ntl
helper module changed path.NOTES
I am not sure what is the expected approximate time to run the benchmark tests, but if it was reasonable we could add these to Travis CI.
As I am writing this, one test (
test_benchmark_hbavss_dealer[33-5]
) appears to hang, or perhaps it just takes a long time:UPDATE: the test in question, was just taking a long time to run ...