initc3 / HoneyBadgerMPC

Robust MPC-based confidentiality layer for blockchains
GNU General Public License v3.0
128 stars 64 forks source link

Fix import errors in some benchmark/test_* #437

Closed sbellem closed 4 years ago

sbellem commented 4 years ago

NOTES

I am not sure what is the expected approximate time to run the benchmark tests, but if it was reasonable we could add these to Travis CI.

As I am writing this, one test (test_benchmark_hbavss_dealer[33-5]) appears to hang, or perhaps it just takes a long time:

UPDATE: the test in question, was just taking a long time to run ...

benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-8] FAILED              [  0%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-16] FAILED             [  1%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-32] FAILED             [  1%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-64] FAILED             [  2%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-128] FAILED            [  2%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-256] FAILED            [  3%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-512] FAILED            [  3%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[4-1-1024] FAILED           [  4%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-8] FAILED              [  4%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-16] FAILED             [  5%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-32] FAILED             [  5%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-64] FAILED             [  6%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-128] FAILED            [  6%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-256] FAILED            [  7%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-512] FAILED            [  7%]
benchmark/test_benchmark_batch_opening.py::test_benchmark_batch_opening[7-2-1024] FAILED           [  8%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[1-5] PASSED                  [  8%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[3-5] PASSED                  [  9%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[5-5] PASSED                  [  9%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[16-5] PASSED                 [ 10%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[33-5] PASSED                 [ 10%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[85-5] PASSED                 [ 11%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[1-25] PASSED                 [ 11%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[3-25] PASSED                 [ 12%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[5-25] PASSED                 [ 12%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[16-25] PASSED                [ 13%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[33-25] PASSED                [ 13%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[85-25] PASSED                [ 14%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[1-50] PASSED                 [ 14%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[3-50] PASSED                 [ 15%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[5-50] PASSED                 [ 15%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[16-50] PASSED                [ 16%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[33-50] PASSED                [ 16%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[85-50] PASSED                [ 17%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[1-100] PASSED                [ 17%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[3-100] PASSED                [ 18%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[5-100] PASSED                [ 18%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[16-100] PASSED               [ 19%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[33-100] PASSED               [ 19%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_lite_dealer[85-100] PASSED               [ 20%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_dealer[1-5] PASSED                       [ 20%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_dealer[3-5] PASSED                       [ 21%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_dealer[5-5] PASSED                       [ 21%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_dealer[16-5] PASSED                      [ 22%]
benchmark/test_benchmark_hbavss.py::test_benchmark_hbavss_dealer[33-5]
codecov[bot] commented 4 years ago

Codecov Report

Merging #437 into dev will decrease coverage by 0.07162%. The diff coverage is n/a.

@@                 Coverage Diff                 @@
##                 dev        #437         +/-   ##
===================================================
- Coverage   77.31423%   77.24261%   -0.07162%     
===================================================
  Files             50          50                 
  Lines           5585        5585                 
  Branches         856         856                 
===================================================
- Hits            4318        4314          -4     
- Misses          1094        1096          +2     
- Partials         173         175          +2     
sbellem commented 4 years ago

When I run benchmark examples locally from this branch, they still do not seem to work: https://gist.github.com/amiller/e945f4b50e4d372f0fabd5072f6a0037

Should be fixed by 64584e0

sbellem commented 4 years ago

The current error on Travis CI is documented in https://github.com/initc3/HoneyBadgerMPC/issues/438.

Will take care of this asap.

UPDATE: fixed via #441.