search

initialxy / cordova-plugin-themeablebrowser

Fork of org.apache.cordova.inappbrowser in an attempt to make it a bit more themeable and configurable to add some custom actions.
Apache License 2.0
294 stars 221 forks source link

UPDATE SOURCE CODE: Merged Repository (for those interested) #193

Open grexican opened 5 years ago

grexican commented 5 years ago

I have merged in most of the PRs on this branch. I'm still testing, so I haven't merged everything into the master branch yet. But if anyone wants to try things out: cordova plugin add https://github.com/grexican/cordova-plugin-themeablebrowser.git#patches

When I merge things back into the main branch, I will let everyone know.

anotherapj commented 5 years ago

Can you also include #71 along with this.

grexican commented 5 years ago

Done.

visortown commented 5 years ago

cordova plugin add https://github.com/grexican/cordova-plugin-themeablebrowser.git#patches

@grexican Thank you for the efforts. There is an error at installation: Using "requireCordovaModule" to load non-cordova module "glob" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.

When running on iOS, it encountered an error: Property 'getCurrentURL' not found on object of type 'CDVThemeableBrowserViewController *'; did you mean 'currentURL'?

grexican commented 5 years ago

@visortown hmmm ok I'll take a look and get 'er running. No merge conflicts before so I took it for granted that it was good to go.

hooliy commented 4 years ago

@grexican very perfect！Thank you for your contribution！