search

initialxy / cordova-plugin-themeablebrowser

Fork of org.apache.cordova.inappbrowser in an attempt to make it a bit more themeable and configurable to add some custom actions.
Apache License 2.0
294 stars 221 forks source link

not building in cordova 6.0.0 with phonegap #79

Closed fidel-ruiz closed 8 years ago

fidel-ruiz commented 8 years ago

when try to build launch some error of incompatibility

ghost commented 8 years ago

Same here. Error messages I'm getting are:

../Plugins/cordova-plugin-themeablebrowser/CDVThemeableBrowser.m:72:19: error: no visible @interface for 'CDVPlugin' declares the selector 'initWithWebView:' self = [super initWithWebView:theWebView];


../platforms/ios/AscentPortfolio/Plugins/cordova-plugin-themeablebrowser/CDVThemeableBrowser.m:320:31: error: no known instance method for selector 'URLIsWhitelisted:'
    if ([self.commandDelegate URLIsWhitelisted:url]) {
ghost commented 8 years ago

Did some research on this. It doesn't look like a easy fix. See below fixes for another plugin on the same issue: https://github.com/Wizcorp/phonegap-facebook-plugin/issues/1199

sencenan commented 8 years ago

Please test the fix.

Sundved commented 8 years ago

Build has been successful but my custom buttons dissapear from ios application :(

sencenan commented 8 years ago

@Sundved cordova 6.0+ has a different asset folder structure. Make sure your resources are listed in the plist file correctly

Sundved commented 8 years ago

@sencenan Thank you, I forgot add my resources( But I think this line need to fix with openInThemeableBrowser method

sencenan commented 8 years ago

Good find. Patched.