search

initiative-sh / initiative.sh

A web-based command line for game masters
https://initiative.sh/
GNU General Public License v3.0
44 stars 4 forks source link

Beach Name Generator #305

Closed ChrisRenfrow closed 1 year ago

ChrisRenfrow commented 1 year ago

I'm fairly happy with this generator in it's current state and believe it to be ready for review. There are some adjustments and/or clean-up to be made (thus the WIP state) but the generator more or less does what it should.

Note: I'm a little rusty when it comes to my git operations so there's a bit of a "git-smell" in my branch. If it's something that needs correcting I'm happy to work through it but AFAIK everything should be in order and ready to merge.

ChrisRenfrow commented 1 year ago

One last adjustment, gem names weren't included in selection due to exclusive range in thing. I also over-corrected to make them occur more, a matter of personal preference.

I'm ready to call this done if you are!

MikkelPaulson commented 1 year ago

Just did a validation pass and got a beach named "Lost Oar Cove". Sometimes the backstory just writes itself. :+1:

Nice work, or as I should more appropriately say- ship it!