search

initios / flake8-junit-report

WARNING: Not mantained
BSD 3-Clause "New" or "Revised" License
14 stars 12 forks source link

Always create junit XML and exit clean #13

Closed Duologic closed 8 years ago

Duologic commented 8 years ago

We are running Flake8 tests with Bamboo, when running the JUnit step of a plan, it expects an XML (even if the tests succeeded. In this pull request, I've modified it so it always outputs an XML, even if there are no failing tests.

Also, I made a small change in the exit-process. Previously it would always exit with exit code 1, while actually the process was successfully. It now prints the success-message and exits with code 0 afterwards.

(I'm an sysadmin, not a developer, so forgive me if I made a dirty mistake somewhere.)

carlosgoce commented 8 years ago

Yes, you are right. It should always create the file even when there are no errors.

I just refactored a few things. I will make a new release with those changes soon.

Duologic commented 8 years ago

:+1:

Duologic commented 8 years ago

Thanks for the new release, I've just made a pull request on our internal code base to use that version.