Docker Version & Auto deploy

initstring / cloud_enum

Multi-cloud OSINT tool. Enumerate public resources in AWS, Azure, and Google Cloud.

MIT License

1.54k stars 224 forks source link

Docker Version & Auto deploy #42

Closed salaheldinaz closed 2 years ago

salaheldinaz commented 2 years ago

[x] Docker version of the tool
[x] GitHub workflow for auto deployment.
[x] Updated Readme file to reflect new changes.

Thanks @initstring for this great tool .

initstring commented 2 years ago

Hi @salaheldinaz ,

Thanks for the PR!

I haven't done a lot of work with Docker Hub or GH actions. Your PR seems to link back to your own version of this project in the README, and also rely on some Docker Hub secrets which I don't have configured myself.

While I appreciate the contribution, I don't feel comfortable merging this for a few reasons:

I don't control the project you link to
I'm not going to set up a docker hub account, and I can't safely link to someone else's

What is the benefit in publishing a docker image for this, when it can just be run in a python3 image? It just seems like something extra to maintain with no added benefit.

salaheldinaz commented 2 years ago

Hi @initstring,

I understand your points.

The docker file is using a python3 based image. I personally need a docker file for the tool to be able to integrate it in automation tools like Argo-Workflows.

Also, few clarification about Docker auto deployment:

The code at beginning of README file is to check for success docker build after pushing the updates to GitHub repo. Just change the username to the desired GitHub name.
GitHub Hub secrets can be obtained from the Docker hub account:
- DOCKER_HUB_ACCESS_TOKEN
- DOCKER_HUB_USERNAME
Happy to help in the future if you decided to create a docker version.

initstring commented 2 years ago

Thanks @salaheldinaz! I appreciate the explanation.

While these do sounds like useful things for various projects, it's not something I want to maintain at the moment. I'm going to close this PR, but I do very much appreciate the contribution!

Happy hacking.