search

initstring / cloud_enum

Multi-cloud OSINT tool. Enumerate public resources in AWS, Azure, and Google Cloud.
MIT License
1.54k stars 224 forks source link

Update gcp_checks.py #53

Closed davidmcduffie closed 2 years ago

davidmcduffie commented 2 years ago

Google Cloud Functions check did not correctly compile the candidates list; each instance of region from the respective config file list would overwrite the last, so only the last region listed was being used. Fix initializes candidates list and changes the replace to an append.

initstring commented 2 years ago

Oh wow, nice catch!!! Thanks so much for taking the time to submit this fix. :)

initstring commented 2 years ago

Hi @davidmcduffie,

There was a previous plan to move this project from GPL to MIT license, discussed here: https://github.com/initstring/cloud_enum/issues/50

I just went ahead and did it, but I realize technically your contribution was to a GPL project. Are you ok with this license change? It affects the PR you submitted, meaning your code will be MIT and not GPL. I just want to make sure you are cool with that.

If not, I understand - just let me know and I will figure out a compliant way to include your fix.

Thanks!

davidmcduffie commented 2 years ago

No issues at all with the license change @initstring, thanks for the heads up and for making this neat tool.