search

initstring / cloud_enum

Multi-cloud OSINT tool. Enumerate public resources in AWS, Azure, and Google Cloud.
MIT License
1.64k stars 241 forks source link

Add JSON output option #67

Closed Fisjkars closed 2 months ago

Fisjkars commented 6 months ago

Hello,

I propose this pull request to add a json output option. This option is useful when you chained your tool with other ones. Our project Redscan (https://github.com/certmichelin/Redscan) use it.

I am open-minded about changes that could be required to merge our feature.

++++

initstring commented 6 months ago

Hi @Fisjkars - thanks for the PR!

The tool already supports JSON output, like this:

cloud_enum.py -k test1234 -l log.json -f json

Have you tried that?

maxime-escourbiac-bib commented 3 months ago

Hello,

Sorry to come back lately, I tried your json output however the format is not a standard one this is why I submitted my PR.

Is it possible to review it again?

Thanks in advance,

initstring commented 2 months ago

Thanks again for your effort. Unfortunately, this MR just adds confusion. There is already an option to do JSON and you've added another instead of modifying the first. Now there are two JSON methods, each doing different things, with a lot of extra code to maintain.

Text formatting should be done in fmt_output in utils.py.