initstring / linkedin2username

OSINT Tool: Generate username lists for companies on LinkedIn
MIT License
1.25k stars 185 forks source link

Fix company name #14

Closed ihack4falafel closed 5 years ago

ihack4falafel commented 5 years ago

You might come across compnies that include reserved characters such as sub-delimiters in their names. Those names need to be URL-encoded when passed as a part of GET parameter. For instance, if the target company name is foo-&-bar-llp this will result in 400 Bad Request due to & sub-delimiter in universalName.

Capture

The fix will make sure its URL-encoded before passing it to the GET http request. Obviously the company name is made up hence the 404 Not Found

Capture

Hopefully the description is good enough.

Thanks!

initstring commented 5 years ago

Hi Hashim,

Wow, thank you for such a great catch and well put together description! I really appreciate you taking the time to submit this.

This is perfect. I am going to merge this PR and then tag a new version as well.

Thanks again, have a great week!