search

initstring / linkedin2username

OSINT Tool: Generate username lists for companies on LinkedIn
MIT License
1.25k stars 185 forks source link

Handle missing key/value pairs better #71

Closed initstring closed 1 year ago

initstring commented 1 year ago

This MR uses a safer method to extract KV pairs from JSON. Missing pairs should now return empty strings instead of KeyErrors. This should fix https://github.com/initstring/linkedin2username/issues/69

initstring commented 1 year ago

I'm running into some issues with this branch and main. Empty name fields are somehow making it through to the writing phase, and then generating key errors.

I think I need to go back and check all the code for where this can happen.

I won't have time to work on this until next week.

initstring commented 1 year ago

I cannot recreate any key errors. It's hard to troubleshoot without that.

I'm going to merge this, and if others report key errors I will continue to squash them.