search

iniwf / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Data races on cpi->b_multi_threaded in vp8/encoder/ethreading.c #856

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
We're detecting racy read/writes on our buildbots on the variable 
cpi->b_multi_threaded:

http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/1528/st
eps/libjingle_peerconnection_unittest/logs/stdio (search for ThreadSanitizer)

An excerpt from the code does the following:
/* shutdown other threads */
cpi->b_multi_threaded = 0;  <-- Concurrent non-atomic write (write without 
proper explicit atomics)

This code might be working fine with just making accesses to b_multi_threaded 
explicitly atomic. I haven't checked the details.

FYI: For now we've suppressed "race:vp8cx_remove_encoder_threads\n" which is 
why it's not showing up in future jobs.

Original issue reported on code.google.com by pbos@google.com on 11 Sep 2014 at 4:37

GoogleCodeExporter commented 9 years ago

Original comment by marpan@google.com on 11 Sep 2014 at 4:38

GoogleCodeExporter commented 9 years ago

Original comment by renganat...@google.com on 9 Oct 2014 at 10:05

GoogleCodeExporter commented 9 years ago 
Yunqing, have we resolved this issue?

Original comment by ya...@google.com on 15 Jan 2015 at 11:37

GoogleCodeExporter commented 9 years ago 
No. This issue wasn't resolved yet. It isn't a trivial issue to fix.

Original comment by yunqingw...@google.com on 16 Jan 2015 at 11:18