search

iniwf / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

libvpx exports some internal assembly symbols. #926

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The libvpx build inside chromium ends up leaving all the symbols defined in 
assembly sources exported, rather than setting their visibility to hidden as is 
typically done for C++ code in chromium by -fvisibility=hidden.

I've been able to fix this in other chromium dependencies by adding the 
relevant ".hidden foo" directives for global symbols, but since libvpx is using 
ARM's assembly syntax and converting it to gas syntax with a script, I'm not 
sure what to do: as far as I can tell ARM's assembler doesn't support setting 
symbol visibility at all.

Maybe the syntax converter should just emit .hidden directives along with 
.global directives?

See http://crbug.com/448386 for more information about what I'm trying to do in 
chromium.

Original issue reported on code.google.com by torne@chromium.org on 19 Jan 2015 at 4:46

GoogleCodeExporter commented 9 years ago

Original comment by torne@chromium.org on 19 Jan 2015 at 4:47

GoogleCodeExporter commented 9 years ago

Original comment by ya...@google.com on 5 Feb 2015 at 8:20

GoogleCodeExporter commented 9 years ago

Original comment by fgalli...@google.com on 12 Feb 2015 at 11:04