search

inkblot / puppet-bind

18 stars 82 forks source link

Update Gemfile, rubocop and cosmetic lint tools #127

Closed cedef closed 7 years ago

cedef commented 7 years ago

@inkblot wrote on #123:

I'm closing this pull request because the commits on this branch have been merged along with additional work to fix the tests.

It has not been merged indeed. I've splitted up my patch as 2 distinct branches that were almost independent. I figured out that without an updated Gemfile/rubocop/Rakefile, new spec tests are of no use as they cannot be run and raise the following error:

require': cannot load such file -- rspec-puppet-facts

To avoid you a small conflict on .gitignore file, I've created a new branch, rebased onto master. This will integrate changes originally proposed as PR #123.

Regards,

inkblot commented 7 years ago

My mistake. I saw "Fix rubocop offenses" at the top of the two histories and assumed you had done some rebasing.

inkblot commented 7 years ago

This change is included in version 7.3.0 of the module published on the Puppet Forge.