search

inkblot / puppet-bind

18 stars 82 forks source link

File resource defaults + allow-recursion #15

Closed 69mb closed 10 years ago

69mb commented 10 years ago

The first commit fixes an issue where concat was failing for me on the first run with the below error since it's file was being realized before the bind package was installed

Error: Could not set 'directory' on ensure: Could not find group bind at 63:/tmp/vagrant-puppet-2/modules-0/concat/manifests/setup.pp

The second commit fixes an issues with views where the specified match-clients will be denied recursion because of the allow-recusion-statement defaults if they are not part of localnets.

inkblot commented 10 years ago

The match_clients and match_destinations used in the allow-recursion and allow-recursion-on clauses are the very same clients and destinations that have access to the view at all. Adding these clauses only affirms the configuration specified by the view's match-clients and match-destinations combined with the recursion directive without affecting anything.

inkblot commented 10 years ago

For reference, after a pull request is sent the owner of the target branch has write access to the source branch of the request. For this pull request, that means I have write access to your master branch. I'll avoid pushing any commits to your master branch, but I do have some changes I'd like to include in your request. I've sent a pull request with my changes which with be included in this one if you accept it.

inkblot commented 10 years ago

Ok, so I meant to make a pull request against your master branch but made it against mine accidentally. I'll try again.