search

inkdevhub / swanky-cli

The all-in-one developer environment for Parity pallet-contracts based smart contracts!
https://docs.astar.network/docs/build/wasm/swanky-suite/cli/
MIT License
70 stars 29 forks source link

surpress version dup warnings #142

Closed shunsukew closed 1 year ago

shunsukew commented 1 year ago

Fixes https://github.com/AstarNetwork/swanky-cli/issues/139

codespool commented 1 year ago

I don't think simply removing the resolution field will fix this problem, as we had it without that field too. That being said, I'm OK with removing it, as it doesn't prevent it neither. But in that case, please remove the locks from other packages and the template too.

shunsukew commented 1 year ago

I don’t remove resolutions. Rather I added resolutions to project root package.

shunsukew commented 1 year ago

@codespool Which changes are you specifically mentioning about?

codespool commented 1 year ago

I don’t remove resolutions. Rather I added resolutions to project root package.

Oh wow, I messed up checking out the PR on my local repo 🤦‍♂️ And this removes the warnings for you?

codespool commented 1 year ago

I get a warning about even one more copy now.

shunsukew commented 1 year ago

@codespool Actually I don’t get warnings. Did you try node modules cleanup and yarn install?

codespool commented 1 year ago

Still get it.. But ok, let's merge - if it fixes it for you, probably gonna fix it for the users too.