search

inkdevhub / swanky-cli

The all-in-one developer environment for Parity pallet-contracts based smart contracts!
https://docs.astar.network/docs/build/wasm/swanky-suite/cli/
MIT License
70 stars 29 forks source link

Update `swanky check` #195

Closed prxgr4mm3r closed 4 months ago

prxgr4mm3r commented 5 months ago

Checkbox 4 from the original issue #114 is not fully completed:

fetch and store the dependency table on init and check use

We should update node.supportedInk version in swanky config when performing the checkCliDependencies task in the init command. You can make and helper performing the semver.gt against our cargo-contract dependencies map like you did in "Verify ink version" from the check command. Then update the node.supportedInk version in swanky config accordingly.

@ipapandinas Sorry, I don't understand properly what you mean by updating node.supportedInk. I thought that it should be set initially in nodeInfo for every SwankyNode version. Can you explain what factors affect the update of the node.supportedInk?

pmikolajczyk41 commented 4 months ago

why was it closed instead of merged? @ipapandinas

ipapandinas commented 4 months ago

I created a single PR #205 to address the overlap between features and to prepare for the upcoming release. I closed this particular one due to significant conflicts. @pmikolajczyk41

pmikolajczyk41 commented 4 months ago

@ipapandinas okay, I was just confused that the other 3 PRs were merged, so I wanted to ensure - thanks!