search

inkdropapp / inkdrop-vim

Provides Vim modal control for Inkdrop, blending the best of Vim and Inkdrop
https://www.inkdrop.app/
MIT License
101 stars 9 forks source link

Mark commands do not work #18

Closed oniatsu closed 4 years ago

oniatsu commented 4 years ago

Mark commands look like not to work. Is it only on my PC? https://github.com/inkdropapp/inkdrop-vim/blob/master/keymaps/vim.json#L85-L87

When I set other key to the commands, but the marking did not work in a similar way.

Other keybinds work correctly. (ex: f vim:find)

craftzdog commented 4 years ago

Oops, there are duplicate keybindings:

"\"": "vim:move-to-mark"
"\"": "vim:register-prefix"

vim:move-to-mark should be bound with ' as the original CodeMirror implementation:

https://github.com/inkdropapp/inkdrop-vim/blob/master/src/keymap.js#L111

craftzdog commented 4 years ago

landed in v2.1.1🎉

oniatsu commented 4 years ago

Thank you for quick fix!