search

inkeliz / karmem

Karmem is a fast binary serialization format, faster than Google Flatbuffers and optimized for TinyGo and WASM.
BSD 3-Clause "New" or "Revised" License
653 stars 27 forks source link

Correction on Golang+Protobuf comment #92

Closed phillip-elm closed 1 year ago

phillip-elm commented 1 year ago

This library looks pretty cool! That said, there's an incorrect statement in the README:

That is something that Google Protobuf doesn't have, and malformed content will cause panic.

This is untrue. proto.Unmarshal returns an error when the data received isn't valid. gRPC would never be taken seriously if it fell over when a bad message is received...

inkeliz commented 1 year ago

I think I confuse Google Protobuf and Google Flatbuffers, since the names are similar and all benchmarks are comparing against Flatbuffers. In that case, Flatbuffers doesnt have any validation: https://github.com/google/flatbuffers/issues/5367.

I'll fix that message soon.