inkle / ink-unity-integration

Unity integration for the open source ink narrative scripting language.
http://www.inklestudios.com/ink
Other
571 stars 99 forks source link

Choices diverting to wrong knots #90

Closed MarianaCacique closed 5 years ago

MarianaCacique commented 5 years ago

Hey! I'm prototyping a narrative game using inky-unity integration. It seemed to be going fine, but after adding my lastest ink file, I noticed the choices are diverting to the wrong knots. What is happening is that I have passages 1>2>3>4>5>6>7 in inky and it goes on the right order there. In Unity it's going 1>2>4>5>3>4>5>7. This is the function I'm using for the choices/diverting: image

Thank you for any help, I really need it!

tomkail commented 5 years ago

Hmm that’s weird, but I’ll need more information. Simply making choices should be rock solid so I imagine there’s something else going on. Can you send over the file?

On Wed, 18 Sep 2019 at 20:16, MarianaCacique notifications@github.com wrote:

Hey! I'm prototyping a narrative game using inky-unity integration. It seemed to be going fine, but after adding my lastest ink file, I noticed the choices are diverting to the wrong knots. What is happening is that I have passages 1>2>3>4>5>6>7 in inky and it goes on the right order there. In Unity it's going 1>2>4>5>3>4>5>7. This is the function I'm using for the choices/diverting: [image: image] https://user-images.githubusercontent.com/33615165/65178428-8c9c6300-da0d-11e9-93e9-dbc6c1ea92bc.png

Thank you for any help, I really need it!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/inkle/ink-unity-integration/issues/90?email_source=notifications&email_token=AAJR3UDEPWS7VGLIYFXX6MTQKJ47JA5CNFSM4IYCWZ32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMHKIEQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJR3UABPTDKGBUWK25C6FLQKJ47JANCNFSM4IYCWZ3Q .

MarianaCacique commented 5 years ago

Here is the ink file! VerticalSlice.zip

tomkail commented 5 years ago

Hate to say it, but it all seems fine on my end. It runs as Id expect from what I can see in inky and unity. I’d try recompiling it in unity, but it should do that automatically when any changes are made. Can you explain what you mean by the numbering?

On Wed, 18 Sep 2019 at 21:30, MarianaCacique notifications@github.com wrote:

Here is the ink file! VerticalSlice.zip https://github.com/inkle/ink-unity-integration/files/3628243/VerticalSlice.zip

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/inkle/ink-unity-integration/issues/90?email_source=notifications&email_token=AAJR3UD4CGCOKYUFOXMVWUDQKKFXJA5CNFSM4IYCWZ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7BLFZY#issuecomment-532853479, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJR3UF4THV3YQX6XNKKK2DQKKFXJANCNFSM4IYCWZ3Q .

MarianaCacique commented 5 years ago

The numbering is from top to bottom. For example, it means it skips ballroom_div1 between ballroom and ballroom_div2, but after gideon you go to ballroom_div1, not gideon_div1. It's working fine in inky, that's why I'm confused.

tomkail commented 5 years ago

Right yeah that’s what I assumed. I tested on the development branch but that shouldn’t make any difference; do make sure you’re on the latest version though. Other than that, I’d start cutting things out until you find the smallest reproduction, it might help work out what’s going on? Can you share more details? None of it should matter but unity version/package version/where you’re testing (play mode/editor window) ect.

On Wed, 18 Sep 2019 at 22:15, MarianaCacique notifications@github.com wrote:

The numbering is from top to bottom. For example, it means it skips ballroom_div1 between ballroom and ballroom_div2, but after gideon you go to ballroom_div1, not gideon_div1. It's working fine in inky, that's why I'm confused.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/inkle/ink-unity-integration/issues/90?email_source=notifications&email_token=AAJR3UHIABM3VYKOP7II3LLQKKK6DA5CNFSM4IYCWZ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7BPE3Q#issuecomment-532869742, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJR3UCEOKIW6TGRRR3FF2DQKKK6DANCNFSM4IYCWZ3Q .

MarianaCacique commented 5 years ago

I tried changing the names(in case it was something about the naming convention), but it didn't work. Here is some info: Unity version: 2019.2.3f1 Ink Unity Integration version: 0.9.1 It works fine in the Ink Player and in Inky. In Playmode and in the build it doesn't work. image Here is the code that assigns the choice to the buttons, just in case I'm doing it wrong.

MarianaCacique commented 5 years ago

Managed to fix it!! The problem was that one of choice button was permanent in the scene(due to gameplay reasons), and when adding the OnClickChoiceButton to its OnClick delegate, I didn't clear all listeners (because it was not needed for any other button). Thank you for your patience!!

tomkail commented 5 years ago

Haha well done :)

On Thu, 19 Sep 2019 at 02:01, MarianaCacique notifications@github.com wrote:

Closed #90 https://github.com/inkle/ink-unity-integration/issues/90.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/inkle/ink-unity-integration/issues/90?email_source=notifications&email_token=AAJR3UH4ZZZGFQZ7IQOJVTTQKLFQBA5CNFSM4IYCWZ32YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTWWKMQA#event-2645337664, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJR3UGM5O2OUM2SHWLJUBTQKLFQBANCNFSM4IYCWZ3Q .