inkle / ink

inkle's open source scripting language for writing interactive narrative.
http://www.inklestudios.com/ink
MIT License
3.97k stars 482 forks source link

TagsAtStartOfFlowContainerWithPathString skipping tags for knots with a parameter #854

Open Rhuantavan opened 1 year ago

Rhuantavan commented 1 year ago

I have encountered an issue when tags are ignored by TagsForContentAtPath(string path) for a knot that contains a parameter. Example:

=== Util_DigMound(container_id) ===

MiniNarrative

"It looks like something's buried here," PARTY_RAND said<>

I have narrowed the problem to TagsAtStartOfFlowContainerWithPathString in Story.cs. If the content begins with a variable assignment, the initial tags will be ignored. I have fixed the issue by adding:

var v = c as Runtime.VariableAssignment; if (v != null) { continue; }

just before

var command = c as Runtime.ControlCommand;

in the foreach loop.

ShiJbey commented 6 days ago

+1 on this issue in version 1.1.8. Thank you for the quick fix.