inkle / inky

An editor for ink: inkle's narrative scripting language
http://www.inklestudios.com/ink
2.41k stars 295 forks source link

Enhancement:Find and Replace #190

Open a2937 opened 5 years ago

a2937 commented 5 years ago

This editor should be able to support find and replace as to make navigating and modifying the scripts much easier. If this is still being worked on, I would love to try to make a pull request to add the required functionality.

Liance commented 4 years ago

Commenting on this one (even though it's old, sorry!) because I think it's still a problem people run into regularly.

Right now Find and Replace functionality is provided by the Ace editor that Inky is built on - but the only way to access that are via the keyboard shortcuts Ctrl + H or Ctrl+F, Ctrl+F.

This isn't obvious (most people default to Ctrl+R, which defaults to "Reload Page") and isn't signposted anywhere else in the app.

My suggestion is that we hook up this existing functionality (find and findAll in app/renderer/acesrc/ace.js respectively) to the application menu, which is probably sufficient to surface Find and Replace functionality for anybody who is looking for it.

See below:

image

Unfortunately, I've tried doing this myself, but don't have sufficient experience to hook up Ace functionality to a menu call - but this seems like a pretty easy task for someone with any sort of js or electron experience though 😄