Inkjs with Ink v1.0.0 support - Githubissues

inkle / inky

An editor for ink: inkle's narrative scripting language

http://www.inklestudios.com/ink

2.41k stars 295 forks source link

Inkjs with Ink v1.0.0 support #345

Closed smwhr closed 3 years ago

smwhr commented 3 years ago

Version of inkjs that supports v1.0.0 of ink is almost ready ! 🥳

I'm preparing a PR with the following

[x] bump inkjs version in inky
[x] export correct inkjs version in default webplayer
[x] use regular inklecate to generate js/web files
[x] use jsonComm all the time

I was wondering if you wanted to

keep the current inkJsCompatible variable in place
keep a separate folder for the inkjs-compatible inklecate binaries to deal with future incompatibilities without having to do the plumbing again. Or if you'd rather clean all up. Let me know !

joethephish commented 3 years ago

Hooray!

I think probably the most stable thing is to have a redundant duplicate of the same inklecate within the inkjs-comaptible folder. Seems a little silly and wasteful, but it's no worse than it is right now, and it means that when eventually break compatibility again, we don't have to think too hard to do the right thing.