So a friend of mine is using Ink to write a story with Chinese characters, and thusly is writing the character names using Pinyin with diacritics for the tones. This was fine, until they hit one particular name where the diacritic was off to the right of the letter it should have been above. I wondered if it was a font issue, and decided to make a fork of Inky to see if I could figure out what the issue was. Below are examples of how various diacritics render:
I've done a fix here, but since I haven't contributed to an open source project before, it was suggested to me that I open an issue first before submitting a PR. Ultimately, all I did was remove Verdana from the font list in main.css and include system-ui and -apple-system in its place. As far as I've been able to tell, Segoe UI and the default iOS font support all diacritics. I was not able to test Linux. Below is a demonstration of the fix:
I changed the weight from "lighter" to 400 since "lighter" was invoking Segoe UI Light which was difficult to read.
Anyway, hoping that this is useful! At the very least, if my solution isn't the correct one, I hope the information here is of some benefit.
So a friend of mine is using Ink to write a story with Chinese characters, and thusly is writing the character names using Pinyin with diacritics for the tones. This was fine, until they hit one particular name where the diacritic was off to the right of the letter it should have been above. I wondered if it was a font issue, and decided to make a fork of Inky to see if I could figure out what the issue was. Below are examples of how various diacritics render:
Long story short: The perpetrator was the Verdana font. The Verdana font that the previewer uses on Windows doesn't support the caron diacritic, nor does it support a couple instances of the breve diacritic. Here's the wikipedia page on the breve diacritic with a comparison against caron diacritics.
I've done a fix here, but since I haven't contributed to an open source project before, it was suggested to me that I open an issue first before submitting a PR. Ultimately, all I did was remove Verdana from the font list in main.css and include system-ui and -apple-system in its place. As far as I've been able to tell, Segoe UI and the default iOS font support all diacritics. I was not able to test Linux. Below is a demonstration of the fix:
I changed the weight from "lighter" to 400 since "lighter" was invoking Segoe UI Light which was difficult to read.
Anyway, hoping that this is useful! At the very least, if my solution isn't the correct one, I hope the information here is of some benefit.