Web player tag capitalisation fix

inkle / inky

An editor for ink: inkle's narrative scripting language

http://www.inklestudios.com/ink

2.42k stars 296 forks source link

Web player tag capitalisation fix #450

Closed elliotherriman closed 2 years ago

elliotherriman commented 2 years ago

I've seen a few people now get confused by the undocumented requirement for tags to be capitalised in order to work with the web player. This tweak automatically capitalises tags before comparison, so #clear will function identically to #CLEAR.

joethephish commented 2 years ago

Thanks!

By the way, I saw you closed your other old pull request for scrolling fixes. Was that just because I never merged it? TBH I'm happy to blindly merge if you're happy with it and have tested it extensively (especially if you've shared the code with other happy customers :)

(Also, looking at the diffs, it seems like we have a tabs/spaces mixture or something - indenting is inconsistent when viewing on GitHub)

elliotherriman commented 2 years ago

Hah, I'll be entirely honest with you, I do not remember any sort of old pull request, so I must have closed it by accident. Still, glad we could (hopefully) get this sorted!

joethephish commented 2 years ago

Hah! Just looked it up, it's this one: https://github.com/inkle/inky/pull/367

This is apparently why it was closed:

elliotherriman commented 2 years ago

Ah, yep! I have a good explanation for that, but I think this comic sums it better than I ever could.

joethephish commented 2 years ago

🤣 yeah, join the club!