inklewriter / freeinklewriter

The libre version of inklewriter, in agreement with inklestudios.
GNU Affero General Public License v3.0
128 stars 29 forks source link

URL preview showing a different story teaser #18

Closed cliftonb closed 4 years ago

cliftonb commented 4 years ago

This repository's issues are reserved for feature requests and bug reports.

Here's my tweet showing two different stories with the same preview text. None of those stories include that text. https://twitter.com/CliftonB/status/1257393102794428417

This is all a lot of steps to report something that was pretty clear in that tweet, but:

  1. Create an inklewriter story
  2. Hit Share and copy then URL provided
  3. Paste the URL in an SMS to someone
albancrommer commented 4 years ago

The reason is pretty simple and related to the way we recovered and rebuilt the app from HTML capture.

To fix the bug, these informations should be added to any "View Story" HTML page:

Such as:


<div class="chunk">

    
   <h1>The Adventure of the Musgrave Ritual</h1>
   <h2>Sir Arthur Conan Doyle</h2>
    
    
   <div class="stitch_block">
   <div class='stitch openingStitch'>
   &lt;i&gt;From the &lt;b&gt;Memoirs of Sherlock Holmes&lt;/b&gt;.&lt;/i&gt;
   </div>
   </div>
    
   <!-- Initial options -->
   <div class="stitchBlock">
   <div class='option_button'>Part One: A Cold Night in London</div>
   </div>
    
   </div>

Instead of this, which appears for every story:


<div class="chunk">
    
    
   <!-- Initial options -->
   <div class="stitchBlock">
   <div class='option_button'>&quot;Well, just one then.&quot;</div>
   <div class='option_button'>&quot;No, I really must go.&quot;</div>
   </div>
    
   </div>
    
   </div>
jeremydouglass commented 4 years ago

https://github.com/inklewriter/freeinklewriter/blob/131e38d717b8e5e750e3e42ebf43fccdd466434c/app/views/stories/show.html.erb#L74-L77

albancrommer commented 4 years ago

It is now fixed and live in production cf. https://www.inklewriter.com/stories/5284

jeremydouglass commented 4 years ago

Tested here:

https://twitter.com/jeremydouglass/status/1258442516329684992