search

inkling / Subliminal

An understated approach to iOS integration testing.
Other
756 stars 54 forks source link

"SLWaitUntilTrue" can be confused with "SLAssertTrueWithTimeout". #236

Closed wearhere closed 10 years ago

wearhere commented 10 years ago

As reported by @lisbakke in Gitter:

some of the guys didn't realize that SLWaitUntilTrue required you to listen to the return value. Their fault for not reading the docs, but the name of the function is misleading -- I think the expectation is that it might assert after the timeout.

Perhaps we should rename it to SLIsTrueWithTimeout?

lisbakke commented 10 years ago

Personally, I think that is a good proposed name.

wearhere commented 10 years ago

Ok cool. Replacing this with two actionable issues: #241 and #242.