search

inkstitch / pyembroidery

libembroidery/EmbroideryFormats converted to python
MIT License
71 stars 28 forks source link

JEF files have some serious size limitations #46

Open tatarize opened 5 years ago

tatarize commented 5 years ago

The ability to force write them to a file does not imply they actually will work for a given hoop. They can be written to a file, but that file might not be able to load in Janome's own software if the pattern falls outside the hoop. This might require some kind of feedback call to pass back a warning or such.

AkiraNorthstar commented 5 years ago

With which Software do you work? I use Embird. You can work there first without a Hoop template. It only outputs an error if the design is larger than the selected hoop (writing to jef). If you still choose a too small hoop and transfer the file into the machine, then this also complains, but you can change the frame in the machine again. Or do I understand your text wrong?

tatarize commented 5 years ago

For the mandated formats I try to make sure things work in the software by the manufacturer. And for some of the larger .jef files they won't load in some older Janome software if they fall out of the hoop. I can save and load the data even when larger than every hoop the machine has, and none of the digitizing suites will care, they just load up the stitches if they exist. But, it might be proper to at least note the size constraint and that might require some kind of feedback. Like, the file is saved as a .jef file but not in any way that a machine would accept because it's too large for any hoop.

The internals to the format actually has it output the edge boundaries for the various hoops, and with larger designs this is sometimes outside all of the hoops. This is largely just a note that I might need to care about this limitation in the future or do something about it, or perhaps just warn people like Embird does, or rather provide that a warning that might matter, and the let whatever software uses pyembroidery deal with the nitty gritty doing a warning. It currently loads and saves .jef files but some of the files cannot run on some machines because they physically can't. It's an issue.

wwderw commented 5 years ago

It currently loads and saves .jef files but some of the files cannot run on some machines because they physically can't. It's an issue.

Some of this was solved with the JEF+ format.

I haven't ever had to have a call to send that format out (most of my work is confined to LCs when going out to people), but that newer format for newer machines seems to take care of that issue.

At least from what I can tell, so take it for what that's worth.