search

inlabru-org / inlabru

inlabru
https://inlabru-org.github.io/inlabru/
78 stars 21 forks source link

Issues with next version of ggplot2 #158

Closed thomasp85 closed 1 year ago

thomasp85 commented 1 year ago

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that the issues are due to our switch to using the linewidth aesthetic for stroke width instead of size. Please see https://www.tidyverse.org/blog/2022/08/ggplot2-3-4-0-size-to-linewidth/ for more info on this.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards Thomas

finnlindgren commented 1 year ago

Thanks! I looked into this when I saw one of your comments on twitter (I think?) a few weeks back but hadn't got around to properly checking&fixing. Will get on it. Btw, I greatly enjoyed your online live sessions on ggplot during the height of the pandemic. Very useful!

finnlindgren commented 1 year ago

Fixed in ggpolypath 0.2.0.