search

inlabru-org / inlabru

inlabru
https://inlabru-org.github.io/inlabru/
76 stars 21 forks source link

Make sure internal names don't clash with user component names #33

Closed finnlindgren closed 1 year ago

finnlindgren commented 6 years ago

Internally, "y" and "e" are used for the observations and Poisson likelihood exposures. This is likely to cause problems if anything on the RHS of a formula or component specification happens to use those names for something else.

Using a prefix, like "BRUy" and "BRUe" would be safer.

finnlindgren commented 6 years ago

The code already uses y.inla in the formula; to make the multiple likelihoods code safe, this (or some other) special name should be used earlier in the stack construction as well.

finnlindgren commented 6 years ago

"bru.offset" is used within the stack. A consistent prefix for all these special variables would be helpful; BRU.offset, BRU.obs, BRU.E, BRU.Ntrials, etc