inlets / inletsctl

Create inlets servers on the top cloud platforms
https://docs.inlets.dev/
MIT License
463 stars 61 forks source link

support downloading into a folder with a space #63

Closed wingkwong closed 3 years ago

wingkwong commented 4 years ago

Signed-off-by: wingkwong wingkwong.code@gmail.com

Description

support for downloading ineltsctl into a folder with space.

How Has This Been Tested?

Before:

test folder with space wingkwong$ ../get.sh 
../get.sh: line 66: [: too many arguments
Downloading package https://github.com/inlets/inletsctl/releases/download/0.5.2/inletsctl-darwin.tgz as /Users/wingkwong/Documents/GitHub/inletsctl/test folder with space/inletsctl-darwin.tgz
curl: (6) Could not resolve host: folder
curl: (6) Could not resolve host: with
curl: (6) Could not resolve host: space
Download Failed!

After:

test folder with space wingkwong$ ../get.sh 
Downloading package https://github.com/inlets/inletsctl/releases/download/0.5.2/inletsctl-darwin.tgz as /Users/wingkwong/Documents/GitHub/inletsctl/test folder with space/inletsctl-darwin.tgz
Download Complete, extracting /Users/wingkwong/Documents/GitHub/inletsctl/test folder with space/inletsctl-darwin.tgz to /Users/wingkwong/Documents/GitHub/inletsctl/test folder with space/ ...
OK
SHA256 fetched from release: 390702b416ec6df83792c76e2f24bc648c78d6d9ce5b91800eb927e7538e4fd3

Running with sufficient permissions to attempt to move inletsctl to /usr/local/bin
New version of inletsctl installed to /usr/local/bin
 _       _      _            _   _ 
(_)_ __ | | ___| |_ ___  ___| |_| |
| | '_ \| |/ _ \ __/ __|/ __| __| |
| | | | | |  __/ |_\__ \ (__| |_| |
|_|_| |_|_|\___|\__|___/\___|\__|_|

Version: 0.5.2
Git Commit: 1744d8982db69d919eb75041a5edda3d670eea28

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

alexellis commented 3 years ago

Thank you for the PR :+1: