search

inlife / nexrender

📹 Data-driven render automation for After Effects
https://www.nexrender.com
MIT License
1.64k stars 325 forks source link

Allow specifying s3ForcePathStyle for s3 provider. #1000

Open lazaroofarrill-opstalent opened 4 months ago

lazaroofarrill-opstalent commented 4 months ago

Is your feature request related to a problem? Please describe. I want to use Minio locally instead of S3 to speedup the render tests. With the version of the AWS SDK used the endpoint behavior is buggy when URL resolution is in virtual host mode. The easiest way to avoid this is forcing path.

This is the error I get when s3 using virtual host style with local Minio instance.

UnknownEndpoint: Inaccessible host: `remake-staging-prod-result-mno1f0aw.localhost' at port `undefined'.

Describe the solution you'd like Allow setting the s3 path style either via a parameter or an environment variable when using a custom endpoint.

Describe alternatives you've considered Allow passing a custom s3 clients to the render job. This might be more flexible when building of top of nexrender core like I am but it would not be portable to users of the server or the cli.

Additional context This is is what I did to my local dependency to get Minio working locally.

image
inlife commented 3 months ago

That sounds reasonable, I think the path style can be a good addition.

lazaroofarrill-opstalent commented 3 months ago

Would you like me to make a PR?

inlife commented 3 months ago

I would love it if you did!

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.