search

inlife / nexrender

📹 Data-driven render automation for After Effects
https://www.nexrender.com
MIT License
1.62k stars 326 forks source link

Update Google Storage provider to use latest version of @google-cloud/storage #973

Closed chrisapplegate closed 7 months ago

chrisapplegate commented 7 months ago

The @google-cloud/storage package in current use is quite outdated and has a bunch of npm audit alerts, so I took the liberty of upgrading it to the latest stable version. The API is exactly the same so no changes in code are needed

Running npm install here updated one lockfile and added another, I hope this is OK - if I need to revert these or change them, let me know, thanks.

inlife commented 7 months ago

Oh, thanks for the update @chrisapplegate! Very neat! 🙏

One minor comment: would it be possible to remove the package-lock.json for the action module, if that's not too much to ask? There are typically some complications for the cases when the locked binaries are packaged if lock files are present in sub-packages.

chrisapplegate commented 7 months ago

@inlife Done!

inlife commented 7 months ago

Awesome, thanks!!